feat: apply consistent validation pattern to PDF write functions #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Extended the robust validation pattern from pdf_write_color to other PDF write functions to prevent crashes from invalid inputs: - pdf_write_move: validates X,Y coordinates for NaN/infinity - pdf_write_line: validates X,Y coordinates for NaN/infinity - pdf_write_line_width: validates width > 0, handles NaN/infinity All functions now: - Use IEEE_ARITHMETIC for NaN/infinity detection - Apply sensible defaults (0.0 for coords, 1.0 for width) - Log debug information when corrections are applied - Follow consistent error handling pattern from PR #325 Added comprehensive test coverage: - test_pdf_write_validation.f90: edge case validation tests - test_pdf_stream_output.f90: verify corrected stream output - test_pdf_validation_performance.f90: minimal overhead verification Ensures consistent defensive programming across all PDF I/O operations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
krystophny
force-pushed
the
refactor-consistent-validation-321
branch
from
7afaf6e to
e03de48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pdf_write_colorto other PDF write functionspdf_write_move,pdf_write_line, andpdf_write_line_widthChanges Made
pdf_write_move: Validates X,Y coordinates, defaults invalid values to 0.0pdf_write_line: Validates X,Y coordinates, defaults invalid values to 0.0pdf_write_line_width: Validates width > 0, defaults invalid values to 1.0Test Coverage
test_pdf_write_validation.f90: Comprehensive edge case validation teststest_pdf_stream_output.f90: Verifies corrected values written to PDF streamtest_pdf_validation_performance.f90: Confirms minimal performance overheadBenefits
Fixes #321
🤖 Generated with Claude Code